Skip to content

Update ERC-5218: update broken foundry link #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

polytur
Copy link
Contributor

@polytur polytur commented Mar 14, 2025

Hi! The old link pointed to an outdated path (foundry-rs/foundry/tree/master/forge), which no longer exists.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 14, 2025

File ERCS/erc-5218.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

@polytur polytur marked this pull request as ready for review March 14, 2025 12:25
@polytur polytur requested a review from eip-review-bot as a code owner March 14, 2025 12:25
SamWilsn
SamWilsn previously approved these changes May 13, 2025
@eip-review-bot eip-review-bot enabled auto-merge (squash) May 13, 2025 21:05
eip-review-bot
eip-review-bot previously approved these changes May 13, 2025
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@SamWilsn SamWilsn dismissed stale reviews from eip-review-bot and themself via 098783f May 13, 2025 21:05
@SamWilsn SamWilsn disabled auto-merge May 13, 2025 22:42
@SamWilsn SamWilsn merged commit 1f9dbf6 into ethereum:master May 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants